Skip to content

Conversation

@gbrodman
Copy link
Collaborator

@gbrodman gbrodman commented Jan 8, 2026

We need to have this enabled in sandbox, but we wish to wait to enable it for production to make sure that the implementation is correct and that clients can use it.

Soon we'll want to do something similar (but the opposite) with the old fee extensions, where we only serve them in production (or maybe unit test as well). That will allow us to pass the RST tests that depend on only having the fee extension 1.0.


This change is Reviewable

@gbrodman gbrodman requested a review from jicelhay January 8, 2026 20:42
@jicelhay
Copy link
Collaborator

jicelhay commented Jan 8, 2026

core/src/main/java/google/registry/model/eppcommon/ProtocolDefinition.java line 110 at r1 (raw file):

    }

    public boolean getVisible() {

nit: getVisibility() feel free to ignore if there are too many dependencies.

We need to have this enabled in sandbox, but we wish to wait to enable
it for production to make sure that the implementation is correct and
that clients can use it.

Soon we'll want to do something similar (but the opposite) with the old
fee extensions, where we **only** serve them in production (or maybe
unit test as well). That will allow us to pass the RST tests that depend
on only having the fee extension 1.0.
Copy link
Collaborator Author

@gbrodman gbrodman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gbrodman made 1 comment.
Reviewable status: 0 of 7 files reviewed, 1 unresolved discussion (waiting on @jicelhay).


core/src/main/java/google/registry/model/eppcommon/ProtocolDefinition.java line 110 at r1 (raw file):

Previously, jicelhay (Juan Celhay) wrote…

nit: getVisibility() feel free to ignore if there are too many dependencies.

we're returning a boolean here so i think the best name is actually isVisible

Copy link
Collaborator

@jicelhay jicelhay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jicelhay partially reviewed 7 files.
Reviewable status: 6 of 7 files reviewed, 1 unresolved discussion (waiting on @gbrodman).

@gbrodman gbrodman enabled auto-merge January 8, 2026 21:12
Copy link
Collaborator

@jicelhay jicelhay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

@jicelhay reviewed 1 file and all commit messages, and made 1 comment.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @gbrodman).

@jicelhay
Copy link
Collaborator

jicelhay commented Jan 8, 2026

core/src/main/java/google/registry/model/eppcommon/ProtocolDefinition.java line 110 at r1 (raw file):

Previously, gbrodman wrote…

we're returning a boolean here so i think the best name is actually isVisible

sure!

@gbrodman gbrodman added this pull request to the merge queue Jan 8, 2026
Merged via the queue into google:master with commit 64f6cd9 Jan 8, 2026
9 of 10 checks passed
@gbrodman gbrodman deleted the fee10notInProd branch January 8, 2026 22:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants