Open
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In client query generation code, the function
rlwe_to_lwecomputes anegacyclic_matrix. Later, inrun_simple_ypir_rgsw_on_params, thequery_row_last_rowvector only uses thebpart of the LWE ciphertexts. The negacyclic matrices seem to be useless in this case. I am not sure about the use of thehow_manyvariable in functiongenerate_query_over_prime. Please make sure it is safe to ignore using this variable.This similar fix appears in YPIR's implementation as well.
Here is a quick test that should work well:
cargo run --release --bin inspire -- -v --num-items 32768 --item-size-bits 32768 --dim0 32768The online client time reduces from ~1000ms to ~30ms