Skip to content

Conversation

@ia0
Copy link
Member

@ia0 ia0 commented Jan 15, 2026

We don't run all checks when building the cache anymore.

@ia0 ia0 added the for:maintainability Improves maintainers life label Jan 15, 2026
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request simplifies the CI workflow by refactoring the ci-checks action to handle a single check at a time instead of a list of checks. This removes the need for JSON parsing and simplifies the conditional logic for running steps. The consolidation of tests-* jobs into a single dynamic step is a good improvement. However, I've found a critical issue: a recurring typo in the action file where input.check is used instead of inputs.check. This will prevent most of the checks from running. Please see my detailed comment for a suggested fix.

@ia0 ia0 force-pushed the ci branch 2 times, most recently from 1da223d to e47781a Compare January 16, 2026 10:11
@ia0
Copy link
Member Author

ia0 commented Jan 16, 2026

/gemini review

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request simplifies the ci-checks GitHub Action by changing its input from a list of checks to a single check. This significantly improves the readability and maintainability of the workflow by replacing complex contains(fromJSON(...)) expressions with simple string comparisons. The consolidation of the sharded test steps into a single dynamic step is a particularly nice improvement. The related ci-footprint action is also simplified. Overall, these are great changes. I have one minor suggestion to make the test sharding logic even cleaner by using a built-in GitHub Actions function.

@ia0
Copy link
Member Author

ia0 commented Jan 16, 2026

/gemini review

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request simplifies the CI workflow by refactoring the ci-checks action to handle a single check per invocation instead of a list of checks. This is a great improvement that will likely allow for better parallelization and clearer job definitions in the calling workflows. The removal of the use-cache input and related logic in both ci-checks and ci-footprint actions further streamlines the implementation. The changes are well-executed and improve the maintainability of the CI configuration. I have one minor suggestion to improve the readability of a condition.

@ia0 ia0 force-pushed the ci branch 2 times, most recently from b188793 to 2094515 Compare January 16, 2026 10:26
ia0-review
ia0-review previously approved these changes Jan 16, 2026
ia0-review
ia0-review previously approved these changes Jan 16, 2026
We don't run all checks when building the cache anymore.
@ia0 ia0 merged commit 57d2354 into google:main Jan 16, 2026
27 checks passed
@ia0 ia0 deleted the ci branch January 16, 2026 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

for:maintainability Improves maintainers life

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants