Add optional parameter of product_module_name #50
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jerrymarino
reviewed
Dec 20, 2022
| help='The platform of the device. The value can be ios_device or ' | ||
| 'ios_simulator.' | ||
| ) | ||
| optional_arguments.add_argument( |
Contributor
There was a problem hiding this comment.
@dostrander I tested this out a bit today, and I think you might want to add the argument to the other case. That looks like it's failing the rules_apple PR:
bazelbuild/rules_apple#1785
I added this into our rules_apple and xctestrunner fork for the reference of what I did in an attempt to fix: bazel-ios@52bdfe3
Contributor
There was a problem hiding this comment.
+++ b/test_runner/ios_test_runner.py
@@ -247,6 +247,11 @@ def _AddSimulatorTestSubParser(subparsers):
'prefix with simulator type and os version. '
'E.g., New-iPhone 6 Plus-10.2.')
test_parser.set_defaults(func=_SimulatorTest)
+ optional_arguments = test_parser.add_argument_group('Optional arguments')
+ optional_arguments.add_argument(
+ '--product_module_name',
+ help='The product module name that will be set in the xctestrun file.'
+ )
dostrander
force-pushed
the
derko/add-product-module-name
branch
from
7849b77 to
bd28707
Compare
This will be forwarded into the xctestrun file in the test name doesn't accurately reflect the module underneath
dostrander
force-pushed
the
derko/add-product-module-name
branch
from
bd28707 to
9fa3cb8
Compare
Contributor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will be forwarded into the xctestrun file in the test name doesn't accurately reflect the module underneath