fix(BigTable): Fixes the issue with same qualifier across families.#9921
fix(BigTable): Fixes the issue with same qualifier across families.#9921Rishabh-V merged 1 commit intogoogleapis:mainfrom
Conversation
Rishabh-V
requested review from
a team,
amanda-tarafa,
igorbernstein2 and
jskeet
product-auto-label
bot
added
the
api: bigtable
|
Conformance Test PR: googleapis/conformance-tests#74 |
| } | ||
|
|
||
| if (chunk.Qualifier != null && chunk.Qualifier != owner._currentCell.Column?.Qualifier) | ||
| if (chunk.Qualifier != null && (chunk.Qualifier != owner._currentCell.Column?.Qualifier || familyNameChanged)) |
There was a problem hiding this comment.
What should happen if chunk.Qualifier is null, but the family name has changed? (I don't know enough about the underlying mechanics to know if that's something we should handle.)
There was a problem hiding this comment.
My understanding is that this if condition determines if the current cell should be associated with a new column or not. If the family has changed and qualifier is null, it should be an invalid scenario as per this test case that states that a new column family must have a qualifier. https://github.com/Rishabh-V/conformance-tests/blob/main/bigtable/v2/readrows.json#L50
There was a problem hiding this comment.
Thanks Jon. I will wait for Igor to have a look as well. Meanwhile, conformance tests with new test cases are failing, so that may require some more time to be merged.
2 participants
Closes #9870
I have also added a test case to test this scenario. I will paste the link of that PR in the comment.