fix: allow IsInOp with same dtypes regardless nullable#2466
Merged
chelsea-lin merged 1 commit intomainfrom Feb 20, 2026
Merged
Conversation
product-auto-label
bot
added
size: m
- Update Ibis isin_op_impl to compare types by name, allowing comparisons between columns and literals with different nullability. - Update SQLGlot IsInOp implementation to use dtypes.can_compare for more robust type compatibility checking. - Improve dtypes.can_compare to gracefully handle type coercion failures. - Migrate TPCH verification script to tests/system/large/test_tpch.py for better integration with the test suite.
chelsea-lin
force-pushed
the
main_chelsealin_tpch_regressions
branch
from
1d180eb to
30361b7
Compare
TrevorBergeron
approved these changes
Feb 20, 2026
chelsea-lin
added a commit
that referenced
this pull request
Mar 4, 2026
PR created by the Librarian CLI to initialize a release. Merging this PR will auto trigger a release. Librarian Version: v0.8.3 Language Image: us-central1-docker.pkg.dev/cloud-sdk-librarian-prod/images-prod/python-librarian-generator@sha256:160860d189ff1c2f7515638478823712fa5b243e27ccc33a2728669fa1e2ed0c <details><summary>bigframes: v2.37.0</summary> ## [v2.37.0](v2.36.0...v2.37.0) (2026-03-03) ### Features * Add cloud_function_cpus option to remote_function (#2475) ([4caf74c](4caf74cc)) * add display.render_mode to control DataFrame/Series visualization (#2413) ([7813eaa](7813eaa6)) * Support pd.col expressions with .loc and getitem (#2473) ([ae5c8b3](ae5c8b32)) * add support for Python 3.14 (#2232) ([c25a6d0](c25a6d01)) * Support pd.col simple aggregates (#2480) ([cb00daa](cb00daab)) * add dt.tz_localize() (#2469) ([f70f93a](f70f93a1)) * Update bigquery.ai.generate_table output_schema to allow Mapping type (#2463) ([f7fd189](f7fd1895)) ### Bug Fixes * upload local data through write API if nested JSONs detected (#2478) ([01dc5a3](01dc5a34)) * allow IsInOp with same dtypes regardless nullable (#2466) ([1d81b41](1d81b414)) ### Documentation * Add code examples to configuration docstrings (#2352) ([3c21993](3c21993e)) * Move readme content to new User Guide section (#2464) ([61a9484](61a94845)) * add code sample and docstring for bpd.options.experiments.sql_compiler (#2474) ([867951b](867951bc)) * use direct API for image (#2465) ([8a1a82f](8a1a82f7)) * Fix recall_score doc example (#2477) ([a6f499c](a6f499c1)) * Skip inherited methods, use autosummary only for big classes (#2470) ([a951249](a9512498)) * add bigframes default connection warning (#2471) ([f1bbba2](f1bbba23)) </details>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes 485642936 🦕