Skip to content

style: align anywidget sorting properties with python conventions#2492

Closed
shuoweil wants to merge 3 commits intomainfrom
shuowei-jetski-no-widget
Closed

style: align anywidget sorting properties with python conventions#2492
shuoweil wants to merge 3 commits intomainfrom
shuowei-jetski-no-widget

Conversation

@shuoweil
Copy link
Contributor

@shuoweil shuoweil commented Mar 4, 2026

This PR standardizes the sorting traitlets in TableWidget to strictly use snake_case, adhering directly to the Python style guide for instance variables rather than relying on workarounds to conform to JavaScript conventions.

  1. Removed sync_key dictionary configurations from sort_columns and sort_ascending traitlets in anywidget.py
  2. Updated the frontend table_widget.js to dispatch state using the individual sort_columns and sort_ascending event properties, instead of a combined sort_context.
  3. Rewrote all assertions test against the new separated list property structures.

Fixes #<487761031> 🦕

@shuoweil shuoweil self-assigned this Mar 4, 2026
@shuoweil shuoweil requested review from a team as code owners March 4, 2026 03:43
@shuoweil shuoweil requested a review from chelsea-lin March 4, 2026 03:43
@product-auto-label product-auto-label bot added size: m Pull request size is medium. api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. labels Mar 4, 2026
@shuoweil shuoweil requested a review from TrevorBergeron March 4, 2026 03:43
@shuoweil shuoweil closed this Mar 4, 2026
@shuoweil
Copy link
Contributor Author

shuoweil commented Mar 4, 2026

This change is invalid, delete the merge request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. size: m Pull request size is medium.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant