fix: make theme modules actually configurable, specifically leader
#271
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mehalter
added a commit
to AstroNvim/AstroNvim
that referenced
this pull request
Mar 20, 2024
PR fix opened upstream: goolord/alpha-nvim#271
mehalter
added a commit
to AstroNvim/AstroNvim
that referenced
this pull request
Mar 20, 2024
PR fix opened upstream: goolord/alpha-nvim#271
mehalter
added a commit
to AstroNvim/AstroNvim
that referenced
this pull request
Mar 20, 2024
PR fix opened upstream: goolord/alpha-nvim#271
mehalter
added a commit
to AstroNvim/AstroNvim
that referenced
this pull request
Mar 20, 2024
PR fix opened upstream: goolord/alpha-nvim#271
mehalter
added a commit
to AstroNvim/AstroNvim
that referenced
this pull request
Mar 20, 2024
PR fix opened upstream: goolord/alpha-nvim#271
mehalter
added a commit
to AstroNvim/AstroNvim
that referenced
this pull request
Mar 20, 2024
PR fix opened upstream: goolord/alpha-nvim#271
mehalter
added a commit
to AstroNvim/AstroNvim
that referenced
this pull request
Mar 20, 2024
PR fix opened upstream: goolord/alpha-nvim#271
mehalter
added a commit
to AstroNvim/AstroNvim
that referenced
this pull request
Apr 1, 2024
PR fix opened upstream: goolord/alpha-nvim#271
mehalter
added a commit
to AstroNvim/AstroNvim
that referenced
this pull request
Apr 1, 2024
PR fix opened upstream: goolord/alpha-nvim#271
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am trying to configure the
leaderkey when using thedashboardtheme and noticed that it actually isn't configurable in the current implementation. Thebuttonfunction is using the static value ofleaderand isn't using the value that is being returned with the module. This moves the theme modules to use the configuration tables rather than just returning things since it is just cleaner when wanting to make things configurableFixes #90