-
Notifications
You must be signed in to change notification settings - Fork 39
Create Plugin: Bundle grafana/ui addition script #2356
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
sunker
wants to merge
17
commits into
main
Choose a base branch
from
create-plugin/bundle-grafana-ui-addition
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
5417bd3 to
ab084c4
Compare
mckn
reviewed
Jan 12, 2026
Collaborator
mckn
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have not tested it but code looks solid! Really like the documentation provided with this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This adds an addition script that allows plugins to bundle
grafana/ui. Removing legacy code related to grafana/ui bundling from the templates is handled in this PR.The most complicated part of this script is the modification of the bundler config - in particular the externals array as this code snippet was moved out of the webpack config a while back and the script needs to support both. The i18n script also needs to modify the externals array, so for that reason I've created a utility function for that.
Which issue(s) this PR fixes:
Fixes #2309
Special notes for your reviewer:
📦 Published PR as canary version:
Canary Versions✨ Test out this PR locally via:
npm install @grafana/create-plugin@6.8.0-canary.2356.20816081919.0 # or yarn add @grafana/create-plugin@6.8.0-canary.2356.20816081919.0