Skip to content

Conversation

@alexinthesky
Copy link

@alexinthesky alexinthesky commented Jan 16, 2026

Removed notes about the userStorageAPI feature flag and fallback to localStorage.

What this PR does / why we need it:

This PR updates the doc, since this feature is now GA and not anymore behind a feature flag.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Removed notes about the userStorageAPI feature flag and fallback to localStorage.
@CLAassistant
Copy link

CLAassistant commented Jan 16, 2026

CLA assistant check
All committers have signed the CLA.

@grafana-plugins-platform-bot grafana-plugins-platform-bot bot moved this from 📬 Triage to 🔬 In review in Plugins Platform / Grafana Community Jan 16, 2026
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the user storage documentation by removing references to the userStorageAPI feature flag and the localStorage fallback mechanism, indicating that the user storage feature is now generally available in Grafana 11.5+ without requiring feature flag enablement.

Changes:

  • Removed two bullet points from the important admonition block about feature flag requirements and localStorage fallback behavior

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Clarified user storage feature availability and fallback mechanism.
Co-authored-by: Anna Urbiztondo <anna.urbiztondo@grafana.com>
Copy link
Contributor

@urbiz-grafana urbiz-grafana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, minor suggestions.

Co-authored-by: Anna Urbiztondo <anna.urbiztondo@grafana.com>

- This feature is available in Grafana 11.5 and later under the `userStorageAPI` feature flag. If a plugin uses this feature but it's not enabled in the Grafana instance, the browser `localStorage` will be used as the storage mechanism instead.
- This feature is GA in Grafana 12.0 and after.
- This feature is GA in Grafana 12.0 and later.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: I'd swap the paragraphs so people on 12.0+ doesn't have to keep reading. Maybe rephrasing things a bit:

This feature is available in Grafana 12.0 and later. From Grafana >11.5 and <12.0, the feature is behind a feature flag userStorageAPI. If a plugin uses this feature but it's not enabled in the Grafana instance, the browser's localStorage will be used as the storage mechanism instead.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed!

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

swapped swapped

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: 🔬 In review

Development

Successfully merging this pull request may close these issues.

4 participants