feat: add arg to prevent exit code 1 #2406
Conversation
github-project-automation
bot
moved this to 📬 Triage
in Plugins Platform / Grafana Community
There was a problem hiding this comment.
Pull request overview
This PR adds a --noExitCode flag to the react-detect tool to prevent it from exiting with code 1 when React 19 issues are detected. This is useful for local plugin scanning where non-zero exit codes are undesirable in certain workflows.
Changes:
- Added
noExitCodeboolean argument to the CLI argument parser - Implemented early exit with code 0 when
--noExitCodeflag is set
Reviewed changes
Copilot reviewed 1 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| packages/react-detect/src/bin/run.ts | Added noExitCode to the boolean arguments list and default configuration |
| packages/react-detect/src/commands/detect19.ts | Added conditional early exit with code 0 when noExitCode flag is present |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| if (argv.noExitCode) { | ||
| process.exit(0); | ||
| } | ||
|
|
||
| process.exit(results.summary.totalIssues > 0 ? 1 : 0); |
There was a problem hiding this comment.
The noExitCode flag implementation doesn't affect the error path. When an exception is caught on line 68-74, the process still exits with code 1 regardless of the noExitCode flag. The flag should also apply to error cases to be consistent with its purpose of preventing exit code 1.
| if (argv.noExitCode) { | ||
| process.exit(0); | ||
| } |
There was a problem hiding this comment.
The flag name noExitCode is ambiguous - it suggests preventing all exit codes, when it actually only prevents exit code 1. Consider renaming to noErrorExitCode or ignoreErrors to better reflect its actual behavior.
github-project-automation
bot
moved this from 📬 Triage
to 🔬 In review
in Plugins Platform / Grafana Community
2 participants
What this PR does / why we need it:
Whilst scanning plugins locally it's handy to not have to deal with error exit codes.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
📦 Published PR as canary version:
Canary Versions✨ Test out this PR locally via:
npm install website@5.3.0-canary.2406.21076281185.0 npm install @grafana/react-detect@0.5.0-canary.2406.21076281185.0 # or yarn add website@5.3.0-canary.2406.21076281185.0 yarn add @grafana/react-detect@0.5.0-canary.2406.21076281185.0