Added conditional time windows#555
Open
marcanpilami wants to merge 6 commits intographhopper:masterfrom
Open
Conversation
eb25494 to
76f43ea
Compare
Author
|
The PR was updated since its inception: first version only allowed conditional time window. Current version now also allows to do time window exclusions (so as for example to forbid a place for some vehicle types during some hours, as in our initial use case stated above). To do this, the time window container (TimeWindows), which was already an interface, now allows multiple implementations. This container becomes responsible for giving the list of time windows to apply, dependening on the insertion context. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use case: some vehicles are not allowed to go to some places only at certain times. For example, many european towns restrict "big" trucks during day time to prevent blocking small roads, but small vehicles stay allowed. Or markets at certain hours forbid all but the smallest vehicles. Etc.
So we need a mecanism to make TW optional. This is what is implemented here: TW can now be inherited, implementing a new extension point verifying if the TW should be applied. If not, the TW is reduced to the default TW (infinity, as already used in other classes).
Side note: I've first asked how to do on S/O at https://stackoverflow.com/questions/76993532/jsprit-conditional-time-windows - I'm very open to other solutions of course. This is my first foray into jsprit code so I would understand if it was found lacking in many ways.