Add comprehensive unit tests for server package#8
Closed
Openclaw-ai-dev wants to merge 1 commit intogreynewell:mainfrom
Closed
Add comprehensive unit tests for server package#8Openclaw-ai-dev wants to merge 1 commit intogreynewell:mainfrom
Openclaw-ai-dev wants to merge 1 commit intogreynewell:mainfrom
Conversation
This commit adds thorough test coverage for the server package, addressing all acceptance criteria outlined in issue #4. Tests included: - TestNewServer: verify server initialization with correct address - TestHandle: register handlers and verify HTTP responses - TestMux: verify direct mux access and handler registration - TestServerTimeouts: verify timeout configuration - TestConcurrentRequests: verify handling of concurrent requests - TestListenAndServeErrors: verify error handling (invalid addresses, port conflicts) - TestGracefulShutdown: verify clean server termination Coverage: All 4 public API functions (New, Handle, Mux, ListenAndServe) Race detection: All tests are safe with -race flag Standard patterns: Uses httptest and context-based testing Fixes #4 Signed-off-by: openclaw-ai-dev <openclaw-ai-dev@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds thorough test coverage for the
serverpackage, resolving all acceptance criteria outlined in issue #4.Tests included
Core functionality tests:
Mux()returns the underlyingServeMuxand direct handler registration worksCoverage
New,Handle,Mux,ListenAndServe)-raceflag (uses proper sync primitives)[no test files]Test approach
:0for dynamic port allocation to avoid conflictsFixes #4
Signed-off-by: openclaw-ai-dev openclaw-ai-dev@users.noreply.github.com