Add the recently added character Zibai to the GI Loadouts roster.#501
Add the recently added character Zibai to the GI Loadouts roster.#501sdglitched wants to merge 2 commits intogridhead:mainfrom
Conversation
Signed-off-by: Shounak Dey <shounakdey@ymail.com>
Signed-off-by: Shounak Dey <shounakdey@ymail.com>
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Sorry @sdglitched, your pull request is larger than the review limit of 150000 diff characters
Summary of ChangesHello @sdglitched, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces the recently added character 'Zibai' to the GI Loadouts application. It encompasses the addition of all necessary asset references and character data definitions, ensuring 'Zibai' is fully recognized and available within the system. This update keeps the application current with new game content, providing users with access to the latest character information. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request adds the new character Zibai to the roster. The changes correctly add the character's assets and data files. However, there are two main issues. First, the character's base and ascension stats are placeholders with zero values. While noted in the PR description, this should be marked with a TODO in the code to ensure it's tracked and updated. Second, there are no tests for the new character in test/data/test_char.py. Adding a test case, even with placeholder data, is crucial for maintainability and to verify the character is integrated correctly.
| @@ -0,0 +1,19 @@ | |||
| from ...type.char import BaseStat, Char, CharName | |||
There was a problem hiding this comment.
A new character has been added, but the corresponding tests in test/data/test_char.py are missing. Please add a new pytest.param for Zibai to the test_char test function. Even with placeholder stats, a test case should be added to verify the character is loaded correctly. You can use expected values of 0 for the stats for now.
| base: BaseStat = BaseStat(attack=0, defense=0, health_points=0) | ||
| ascn: BaseStat = BaseStat(attack=0, defense=0, health_points=0) |
There was a problem hiding this comment.
The base and ascension stats for Zibai are all set to 0. While I understand from the pull request description that the stats are not yet available, merging this with zeroed-out values will lead to incorrect data for this character in the application. It's better to add a TODO comment to track this and ensure it gets updated as soon as the stats are available. This will make it clear to future developers that this is placeholder data.
| base: BaseStat = BaseStat(attack=0, defense=0, health_points=0) | |
| ascn: BaseStat = BaseStat(attack=0, defense=0, health_points=0) | |
| # TODO: Update with actual stats once available from the wiki. | |
| base: BaseStat = BaseStat(attack=0, defense=0, health_points=0) | |
| ascn: BaseStat = BaseStat(attack=0, defense=0, health_points=0) |
2 participants
Add the recently added character Zibai to the GI Loadouts roster.
Currently the stats are not available in the wiki.
Closes: #488