use python random instead numpy#1526
Open
maurerle wants to merge 1 commit intogridsingularity:masterfrom
Open
Conversation
maurerle
force-pushed
the
feature/remove-numpy
branch
from
2375994 to
ac8c21e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reason for the proposed changes
Using Numpy for random things does not have a benefit and adds a quite big library for a thing which is also available in the standard python lib
Proposed changes
use pythons random sampling and remove numpy package
INTEGRATION_TESTS_BRANCH=master
GSY_FRAMEWORK_BRANCH=master