Add buyer/seller IDs to CSV fields#302
Conversation
Previously, the CSV exports used to only contain the names of the trading parties. Including the unique IDs makes it easier to connect CSV rows to the corresponding entities.
|
Thanks a lot for your contribution and re-adding the buyer and seller ids to the exported CSV files. We will leave our reviews soon. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #302 +/- ##
=======================================
Coverage 52.58% 52.58%
=======================================
Files 50 50
Lines 3041 3041
Branches 586 586
=======================================
Hits 1599 1599
Misses 1371 1371
Partials 71 71 |
|
Thanks for taking the time to review this external PR! Should I update the branch with the newest changes from master? |
Yes, before pushing a PR to master it should be up to date, let us know when you're done so we can perform another round of review |
|
@Hassan754 Alright, there were no merge conflicts with master. The files I edited remained untouched since my commit. |
Previously, the CSV exports used to only contain the names of the
trading parties. Including the unique IDs makes it easier to connect
CSV rows to the corresponding entities.