Skip to content

Conversation

@susannasiebert
Copy link
Contributor

Closes #1349

This PR fixes two issues:

  1. Some frameshift mutations have no VEP-predicted downstream tail. In the issue example, this is because the transcript amino acid sequence:

MGRARPGQRGPPSPGPAAQPPAPPRRRARSLALLGALLAAAAAAAVRVCARHAEAQAAARQELALKTLGTDGLFLFSSLDTDGDMYISPEEFKPIAEKLTGSCSVTQTGVQWCSHSSLQPQLPWLNUSSCLSLLRSTPAASCEEEELPPDPSEETLTIEARFQPLLPETMTKSKDGFLGVSRLALSGLRNWTAAASPSAVFATRHFQPFLPPPGQELGEPWWIIPSELSMFTGYLSNNRFYPPPPKGKEVIIHRLLSMFHPRPFVKTRFAPQGAVACLTAISDFYYTVMFRIHAEFQLSEPPDFPFWFSPAQFTGHIILSKDATHVRDFRLFVPNHRSLNVDMEWLYGASESSNMEVDIGYIPQMELEATGPSVPSVILDEDGSMIDSHLPSGEPLQFVFEEIKWQQELSWEEAARRLEVAMYPFKKVSYLPFTEAFDRAKAENKLVHSILLWGALDDQSCUGSGRTLRETVLESSPILTLLNESFISTWSLVKELEELQNNQENSSHQKLAGLHLEKYSFPVEMMICLPNGTVVHHINANYFLDITSVKPEEIESNLFSFSSTFEDPSTATYMQFLKEGLRRGLPLLQP

contains a U, resulting in the VEP-predicted mutant sequence getting cut off at the U:

MGRARPGQRGPPSPGPAAQPPAPPRRRARSLALLGALLAAAAAAAVRVCARHAEAQAAARQELALKTLGTDGLFLFSSLDTDGDMYISPEEFKPIAEKLTGSCSVTQTGVQWCSHSSLQPQLPWLN

However, the somatic mutation is after the position of the U, resulting an empty mutant sequence to be extracted, which results in downstream errors when trying to evaluate the first position for an unsupported amino acid. These types of variants can be skipped since they don't produce any novel neoantigen candidates.

  1. In the process of evaluating a first bug a noticed an oddity where restarting a run that had failed during the fasta creation step would no longer incorporate proximal variants. When a run aborts during the fasta creation step and is then restarted the code tries to pick up where it left off. However, the VCF has already been converted to a TSV and the proximal variants have been extracted to a separate TSV. These two steps are not redone but the already existing proximal variant TSV was not being hooked up correctly and the fasta creation step would run as if that TSV didn't exist.

@susannasiebert susannasiebert changed the base branch from master to hotfix December 17, 2025 14:12
@susannasiebert susannasiebert merged commit 63a0023 into hotfix Jan 5, 2026
9 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

mutant_subsequence[0] resulting in Index Error

2 participants