Support for scaling during drawn boxed text#45
Open
Pidroh wants to merge 1 commit intogrimfang4:masterfrom
Open
Support for scaling during drawn boxed text#45Pidroh wants to merge 1 commit intogrimfang4:masterfrom
Pidroh wants to merge 1 commit intogrimfang4:masterfrom
Conversation
When mixing drawBox with scale, text does not wrap up correctly This happens because FC_GetBufferFitToColumn takes scale as a parameter but does not actually scale anything. I solved this problem by adding width = (int)(width / scale.x); To the beginning of FC_GetBufferFitToColumn. There is also a similar problem of scale not being taken into account on the line distance. I fixed it by changing y += FC_GetLineHeight(font); to y += FC_GetLineHeight(font)*scale.y;
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When mixing drawBox with scale, text does not wrap up correctly
This happens because FC_GetBufferFitToColumn takes scale as a parameter but does not actually scale anything. I solved this problem by adding
width = (int)(width / scale.x);
To the beginning of FC_GetBufferFitToColumn.
There is also a similar problem of scale not being taken into account on the line distance. I fixed it by changing
y += FC_GetLineHeight(font);
to
y += FC_GetLineHeight(font)*scale.y;