Skip to content

Add Version check menu Item. #121

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Jaehwa-Noh wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Add Version check menu Item. #121

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
196b01c
Add version check menu item.
Jaehwa-Noh Nov 20, 2023
c1f4cf9
Add String resource for new menu item.
Jaehwa-Noh Nov 20, 2023
0a9f54c
Remove redundant space bar and lines.
Jaehwa-Noh Nov 26, 2023
932c84b
Merge remote-tracking branch 'upstream/master'
Jaehwa-Noh Jan 20, 2024
adb470b
Add string resource for about dialog.
Jaehwa-Noh Jan 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 17 additions & 0 deletions NearDrop/AppDelegate.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@ class AppDelegate: NSObject, NSApplicationDelegate, UNUserNotificationCenterDele
menu.addItem(withTitle: NSLocalizedString("VisibleToEveryone", value: "Visible to everyone", comment: ""), action: nil, keyEquivalent: "")
menu.addItem(withTitle: String(format: NSLocalizedString("DeviceName", value: "Device name: %@", comment: ""), arguments: [Host.current().localizedName!]), action: nil, keyEquivalent: "")
menu.addItem(NSMenuItem.separator())
menu.addItem(withTitle: NSLocalizedString("About", value: "NearDrop Version", comment: ""), action: #selector(showVersionAlert), keyEquivalent: "")
menu.addItem(withTitle: NSLocalizedString("Quit", value: "Quit NearDrop", comment: ""), action: #selector(NSApplication.terminate(_:)), keyEquivalent: "")
statusItem=NSStatusBar.system.statusItem(withLength: NSStatusItem.variableLength)
statusItem?.button?.image=NSImage(named: "MenuBarIcon")
Expand Down Expand Up @@ -53,6 +54,22 @@ class AppDelegate: NSObject, NSApplicationDelegate, UNUserNotificationCenterDele
func applicationSupportsSecureRestorableState(_ app: NSApplication) -> Bool {
return true
}

@objc
func showVersionAlert() {
let alert = NSAlert()
let appVersion = Bundle.main.infoDictionary?["CFBundleShortVersionString"] as? String
alert.alertStyle = .informational
alert.messageText = NSLocalizedString("NotificationsVersion.Title", value: "NearDrop Current Version", comment: "")
if let appVersion = appVersion {
alert.informativeText = appVersion
} else {
alert.informativeText = NSLocalizedString("NotificationVersion.Error", value: "Can't find a version.", comment: "")
}

alert.addButton(withTitle: NSLocalizedString("OK", value: "OK", comment: ""))
alert.runModal()
}

func showNotificationsDeniedAlert(){
let alert=NSAlert()
Expand Down
9 changes: 8 additions & 1 deletion NearDrop/Base.lproj/Localizable.strings
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
/* No comment provided by engineer. */
/* No comment provided by engineer. */
"Accept" = "Accept";

/* No comment provided by engineer. */
Expand Down Expand Up @@ -40,3 +40,10 @@
/* No comment provided by engineer. */
"VisibleToEveryone" = "Visible to everyone";

"About" = "NearDrop Version";

"NotificationsVersion.Title" = "NearDrop Current Version";

"NotificationVersion.Error"="Can't find a version.";

"OK" = "OK";
9 changes: 8 additions & 1 deletion NearDrop/ko.lproj/Localizable.strings
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
/* No comment provided by engineer. */
/* No comment provided by engineer. */
"Accept" = "수락";

/* No comment provided by engineer. */
Expand Down Expand Up @@ -40,3 +40,10 @@
/* No comment provided by engineer. */
"VisibleToEveryone" = "모든 사용자에게 공개";

"About" = "NearDrop 버전";

"NotificationsVersion.Title" = "NearDrop 현재 버전";

"NotificationVersion.Error"="버전 확인 불가.";

"OK" = "확인";