fix: remove t.Parallel() from tests that modify global tracer provider #23
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tests that call otel.SetTracerProvider() were running in parallel, causing race conditions where multiple tests would interfere with each other's global state. This resulted in flaky test failures where rec.requested contained extra entries from other parallel tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Fixes flaky test failures in
TestNewTracerUsesGlobalProviderWhenNoneProvidedwhere the test expected 1 tracer request but received 3.Implementation
t.Parallel()fromTestNewTracerUsesGlobalProviderWhenNoneProvidedandTestNewTracerRespectsCustomProviderOptionotel.TracerProviderviaotel.SetTracerProvider(), which causes race conditions when running in parallel with other tests that also callNewTracer()t.Parallel()for performance