Skip to content

Conversation

@gezalore
Copy link
Contributor

@gezalore gezalore commented Mar 4, 2025

This is useful for coordinating compression between multiple writer instances in parallel.

It is used by verilator/verilator#5806 to coordinate between parallel dumps.

This is useful for coordinating compression between multiple writer
instances in parallel.
@gezalore
Copy link
Contributor Author

Is there anything else you need to land this? I'm happy to provide more info if you would like, please let me know.

Copy link
Contributor

@rfuest rfuest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not very familiar with the internals of the library yet and @tbybell should take another look, but except for a small code quality nit the change looks good to me.

Co-authored-by: Ralf Fuest <mail@rfuest.de>
@gezalore
Copy link
Contributor Author

Thanks, suggestions have applied. I will wait for Tony's feedback.

@tbybell
Copy link
Contributor

tbybell commented Mar 11, 2025

Looks good to me.

@rfuest rfuest merged commit 93e45e6 into gtkwave:main Mar 11, 2025
3 checks passed
@gezalore gezalore deleted the get-flush-pending branch March 11, 2025 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants