Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pr fixes a bug with the core2 gate1 access flow. The core2 listener saves jobs done count by flow id in redis, and since the queues doesn't include it in the job params it gets returned as null.
Because of this running a status update on a role a second time will not trigger the
checkIfAllDonelogic becauseroleSummary.Countwill be more thanallDone.I didn't test it yet just wanted your opinion on it, maybe you'll immediately see if there's something wrong with it. I'm not sure if it will mess up the flows where there's no flowId in the redis hasmap. Although I tried it in redis and it just returns nil in that case.