Skip to content

Comments

[Dcos] standardization with MLRun doc#1

Merged
guy1992l merged 3 commits intoguy1992l:packagers-docsfrom
jillnogold:jg-packagers
Feb 19, 2026
Merged

[Dcos] standardization with MLRun doc#1
guy1992l merged 3 commits intoguy1992l:packagers-docsfrom
jillnogold:jg-packagers

Conversation

@jillnogold
Copy link

📝 Description

Copy link
Owner

@guy1992l guy1992l left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Jill, 2 comments and a question: why did you add packagers-overview.md out of index.md but in custom_packagers you left index.md?

Comment on lines 432 to 437
```{note}
When running remotely, set the project source with `pull_at_runtime=True`
so the packager module can be imported on the remote worker:

project.set_source(source="./", pull_at_runtime=True)
```
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This note is too limited, see ### 8. Make the packager importable on the remote worker in custom_packagers/index.md. We can mention the custom packager needs to be available during runtime so there are 3 options to do so and link to section 8. What do you think?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated

"\n",
"We want the template saved as a readable **JSON** file that captures the message\n",
"structure, and we want to load it back as a `ChatPromptTemplate` in downstream\n",
"Ibstead, the template should be saved as a readable **JSON** file that captures the message\n",
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"Ibstead, the template should be saved as a readable **JSON** file that captures the message\n",
"Instead, the template should be saved as a readable **JSON** file that captures the message\n",

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

@jillnogold jillnogold changed the title standardization with MLRun doc [Dcos] standardization with MLRun doc Feb 19, 2026
@guy1992l guy1992l merged commit 6953754 into guy1992l:packagers-docs Feb 19, 2026
2 checks passed
@jillnogold jillnogold deleted the jg-packagers branch February 19, 2026 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants