Skip to content

Comments

Add project tag to ECR repository#141

Merged
RSkuma merged 1 commit intomainfrom
issue-131-add-project-tag-ecr
Feb 12, 2026
Merged

Add project tag to ECR repository#141
RSkuma merged 1 commit intomainfrom
issue-131-add-project-tag-ecr

Conversation

@Benettonkkb
Copy link
Member

Fixes #131

Inserted on line 17 of `terraform/modules/ecr/main.tf:

  tags = {
    project = var.project_name
  }

Why did you make the changes (we will use this info to test)?

@github-actions
Copy link
Contributor

github-actions bot commented Feb 5, 2026

Terraform plan in terraform
With backend config files: terraform/prod.backend.tfvars

Plan: 0 to add, 7 to change, 0 to destroy.
Terraform used the selected providers to generate the following execution
plan. Resource actions are indicated with the following symbols:
!~  update in-place

Terraform will perform the following actions:

  # module.civic-tech-jobs.module.civic_tech_jobs_ecr_fullstack.aws_ecr_repository.this will be updated in-place
!~  resource "aws_ecr_repository" "this" {
        id                   = "civic-tech-jobs-fullstack"
        name                 = "civic-tech-jobs-fullstack"
!~      tags                 = {
+           "project" = "civic-tech-jobs-fullstack"
        }
!~      tags_all             = {
+           "project"    = "civic-tech-jobs-fullstack"
#            (1 unchanged element hidden)
        }
#        (5 unchanged attributes hidden)

#        (2 unchanged blocks hidden)
    }

  # module.home-unite-us.module.ecr_fullstack.aws_ecr_repository.this will be updated in-place
!~  resource "aws_ecr_repository" "this" {
        id                   = "home-unite-us-fullstack"
        name                 = "home-unite-us-fullstack"
!~      tags                 = {
+           "project" = "home-unite-us-fullstack"
        }
!~      tags_all             = {
+           "project"    = "home-unite-us-fullstack"
#            (1 unchanged element hidden)
        }
#        (5 unchanged attributes hidden)

#        (2 unchanged blocks hidden)
    }

  # module.people-depot.module.dev_database.postgresql_grant.user will be updated in-place
!~  resource "postgresql_grant" "user" {
        id                = "people-depot_backend_dev_user_people-depot_backend_dev_public_table"
!~      privileges        = [
+           "DELETE",
+           "INSERT",
+           "SELECT",
+           "UPDATE",
        ]
#        (5 unchanged attributes hidden)
    }

  # module.people-depot.module.dev_database.postgresql_grant.viewer will be updated in-place
!~  resource "postgresql_grant" "viewer" {
        id                = "people-depot_backend_dev_viewer_people-depot_backend_dev_public_table"
!~      privileges        = [
+           "SELECT",
        ]
#        (5 unchanged attributes hidden)
    }

  # module.people-depot.module.people_depot_ecr_backend.aws_ecr_repository.this will be updated in-place
!~  resource "aws_ecr_repository" "this" {
        id                   = "people-depot-backend"
        name                 = "people-depot-backend"
!~      tags                 = {
+           "project" = "people-depot-backend"
        }
!~      tags_all             = {
+           "project"    = "people-depot-backend"
#            (1 unchanged element hidden)
        }
#        (5 unchanged attributes hidden)

#        (2 unchanged blocks hidden)
    }

  # module.vrms.module.ecr_backend.aws_ecr_repository.this will be updated in-place
!~  resource "aws_ecr_repository" "this" {
        id                   = "vrms-backend"
        name                 = "vrms-backend"
!~      tags                 = {
+           "project" = "vrms-backend"
        }
!~      tags_all             = {
+           "project"    = "vrms-backend"
#            (1 unchanged element hidden)
        }
#        (5 unchanged attributes hidden)

#        (2 unchanged blocks hidden)
    }

  # module.vrms.module.ecr_frontend.aws_ecr_repository.this will be updated in-place
!~  resource "aws_ecr_repository" "this" {
        id                   = "vrms-frontend"
        name                 = "vrms-frontend"
!~      tags                 = {
+           "project" = "vrms-frontend"
        }
!~      tags_all             = {
+           "project"    = "vrms-frontend"
#            (1 unchanged element hidden)
        }
#        (5 unchanged attributes hidden)

#        (2 unchanged blocks hidden)
    }

Plan: 0 to add, 7 to change, 0 to destroy.

✅ Plan applied in Terraform apply (OIDC) #56

@RSkuma RSkuma self-requested a review February 12, 2026 02:16
Copy link
Member

@RSkuma RSkuma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@RSkuma RSkuma merged commit b70b0ec into main Feb 12, 2026
2 checks passed
@Benettonkkb Benettonkkb added this to the 02 - Security milestone Feb 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

add project tag to ecr

2 participants