Skip to content

flash messages can now be closed #97

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ImTheKai merged 1 commit into from
Mar 5, 2026
Merged

flash messages can now be closed #97

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 21 additions & 0 deletions app/assets/stylesheets/components/form.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,27 @@ input[type=submit], input[type=button] {
gap: var(--spacing-2);
}

.flash-message {
flex: 1;
}

.flash-close {
margin-left: auto;
border: 0;
background: transparent;
color: inherit;
font: inherit;
cursor: pointer;
padding: 0;
line-height: 1;
opacity: 0.8;

&:hover,
&:focus-visible {
opacity: 1;
}
}

.flash.alert {
background-color: var(--color-danger-soft);
color: var(--color-danger);
Expand Down
7 changes: 7 additions & 0 deletions app/javascript/controllers/flash_controller.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
import { Controller } from "@hotwired/stimulus"

export default class extends Controller {
dismiss() {
this.element.remove()
}
}
10 changes: 6 additions & 4 deletions app/views/layouts/application.html.slim
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -134,14 +134,16 @@ html data-theme="light"
.layout-sidebar-overlay data-sidebar-target="overlay" data-action="click->sidebar#closeMobile"
main.container
- flash.each do |type, message|
.flash class=type
.flash class=type data-controller="flash"
= flash_icon(type)
= message
span.flash-message = message
button.flash-close type="button" aria-label="Dismiss message" data-action="flash#dismiss" x
= yield
- else
main.container
- flash.each do |type, message|
.flash class=type
.flash class=type data-controller="flash"
= flash_icon(type)
= message
span.flash-message = message
button.flash-close type="button" aria-label="Dismiss message" data-action="flash#dismiss" x
= yield