Open
Conversation
There was a problem hiding this comment.
Pull request overview
This pull request adds Right-to-Left (RTL) text direction support to HACS (Home Assistant Community Store). The changes introduce RTL direction computation and apply it globally, while also providing mechanisms to force LTR (Left-to-Right) display for specific technical content.
Changes:
- Added global RTL direction detection and application to the document root in the main HacsElement
- Introduced
forceLTRparameter for dialogs to handle technical content (version numbers, URLs, GitHub usernames) that should always display left-to-right - Applied code style improvements with consistent trailing commas
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| src/hacs.ts | Imports RTL utilities, applies direction globally in _initializeLocalize, adds trailing commas for consistency |
| src/dashboards/hacs-repository-dashboard.ts | Forces LTR direction for repository content (versions, usernames, stats) |
| src/dashboards/hacs-dashboard.ts | Adds forceLTR parameter to "About HACS" dialog |
| src/components/dialogs/show-hacs-dialog.ts | Defines forceLTR as required parameter in HacsFormDialogParams interface, adds trailing commas |
| src/components/dialogs/hacs-form-dialog.ts | Implements forceLTR support with CSS class, adds state property and styling |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.