Open
Conversation
Contributor
Yeah, the code which matches for modes sorts the results where those having matching country codes are prioritised higher (see below), and should also filter out non-matching county segments. So given each country is so different, I think the segments have "gb" country code for UK, and also "im", "je" and "gg" for the Crown Dependencies. lib-operation-data/src/lib/modes.js Lines 165 to 190 in 64210e4 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
Following a brief discussion between Rich M7GET, Steve M1SDH and myself on the OARC Discord, I thought I would put in a PR for adding a 4m band blan to PoLo (and any other software that uses
lib-operation-data).The challenge however is that the 4m band allocation varies a lot between countries (see Wikipedia) and there is almost no allocation for this band outside Europe.
I have put in a first attempt, which matches the UK band plan, but I'm not clear on exactly what the
countriesfield does and whether I should be using it - it currently seems to just be used to remove all default modes on HF segments for Australian users. Can I use this to set up completely different segments per country on 4m?If you're happy with the RSGB 4m band plan being in there and available to all, this PR should be enough already, but if you would like me to refine it to include the country-by-country allocations, and/or mask it out to make it clearer that there is no allocation in other countries, could you please suggest how the
countriesfield should be used for this?Thanks