Add "work type" badge to help categorize each timer entry#29
Open
rlyders wants to merge 9 commits intohamaluik:masterfrom
Open
Add "work type" badge to help categorize each timer entry#29rlyders wants to merge 9 commits intohamaluik:masterfrom
rlyders wants to merge 9 commits intohamaluik:masterfrom
Conversation
…able', has no unnamed constructor that takes no arguments. fix: flutter_datetime_picker: ^1.3.8 # fixed: Error: The superclass, 'Diagnosticable', has no unnamed constructor that takes no fix: shared_preferences: ^0.5.7+3 # fixed: [deprecation] getFlutterEngine() in FlutterPluginBinding has been deprecated
…er Start Date to Monday") to default the following filters to the latest Monday: dashboard filter, report filter, export filter
…tive Timers") to control whether multiple timers are allowed to run at the same time or not
…table (e.g.: dev(elopment), test(ing), dep(loyment)); added db vers # 2; upgrade db when version # changes feat: added new setting defaultWorkTypeID: this determines the default work type to be given to a new timer feat: added new setting displayProjectNameInTimer: this controls whether the project name (along with work type) are shown in each timer row (running timer, stopped timer, grouped stop timers)
…hboard showing timers with work-type badges applied
…d date range in name of exported file
Owner
|
Hey, Thanks for the pull requests! I haven’t been able to check them out yet but will aim to look at them tomorrow. |
Contributor
Author
|
Hi Kenton,
I hope you find the changes might benefit others enough to justify accepting the pull requests. If you feel they need to be tweaked to improve their acceptance, please let me know. I’m happy to consider adjustments.
I’m actively using the app for my daily timekeeping. As you might guess, these pull requests are based on features that I need, yet I’ve tried to make them more palatable for others.
Thanks for taking the time to consider the changes.
Take care.
PS: I was about to run your “tt” translation program to auto-generate all the language files, but then Google’s $45/hr cost for their translation service gave me pause.
…-Rich
From: Kenton Hamaluik<mailto:notifications@github.com>
Sent: Sunday, May 24, 2020 10:03 PM
To: hamaluik/timecop<mailto:timecop@noreply.github.com>
Cc: rlyders<mailto:Richard@Lyders.com>; Author<mailto:author@noreply.github.com>
Subject: Re: [hamaluik/timecop] Add "work type" badge to help categorize each timer entry (#29)
Hey,
Thanks for the pull requests! I haven’t been able to check them out yet but will aim to look at them tomorrow.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub<https://eur02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fhamaluik%2Ftimecop%2Fpull%2F29%23issuecomment-633352835&data=02%7C01%7C%7C8bf4f302f1d642b4f1b408d800582b4a%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637259725962045704&sdata=YybzKWjxgQ%2BQ7mFZs5DNdpzVL4mzpe6aeLGzLKSk3d8%3D&reserved=0>, or unsubscribe<https://eur02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FABBPDAC576NLUFLGC6ISKBLRTHNXDANCNFSM4NJAR5QA&data=02%7C01%7C%7C8bf4f302f1d642b4f1b408d800582b4a%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637259725962055684&sdata=uOx7T19U6N%2BOYByGri%2FzCbsAj7SP6tRAHwOmcYBT%2BuA%3D&reserved=0>.
|
|
"Work type" seems too specific to me. I feel the more general concept of "tags" would make it more useful to more people. Having said that, I think either would be going against the main idea of keeping the app as minimal as possible. About the idea of appending the Project name in each timer row, I agree it's needed (it's hard to tell the project just by color). Could be an option that can be enabled/disabled in Settings, off by default. |
Contributor
Author
|
Yes, tag is a much better name for that feature. Do you want me to make that change or are you looking at doing it?
Sent from Outlook Mobile<https://aka.ms/blhgte>
…________________________________
From: danielpferreira <notifications@github.com>
Sent: Tuesday, May 26, 2020 8:25:04 AM
To: hamaluik/timecop <timecop@noreply.github.com>
Cc: rlyders <Richard@Lyders.com>; Author <author@noreply.github.com>
Subject: Re: [hamaluik/timecop] Add "work type" badge to help categorize each timer entry (#29)
"Work type" seems too specific to me. I feel the more general concept of "tags" would make it more useful to more people. Having said that, I think either would be going against the main idea of keeping the app as minimal as possible.
About the idea of appending the Project name in each timer row, I agree it's needed (it's hard to tell the project just by color). Could be an option that can be enabled/disabled in Settings, off by default.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub<https://nam01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fhamaluik%2Ftimecop%2Fpull%2F29%23issuecomment-634022852&data=02%7C01%7C%7C94acd3151f8d41a064af08d8017833a8%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637260963050447609&sdata=iwvQFJY93eo4cvriVCgdYCfg%2FrdZSsCGhBPf33XPsdA%3D&reserved=0>, or unsubscribe<https://nam01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FABBPDAFAXNR65HKT56EONW3RTO7LBANCNFSM4NJAR5QA&data=02%7C01%7C%7C94acd3151f8d41a064af08d8017833a8%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637260963050457602&sdata=1uK5%2B15h5ZQye4%2FIjXhjKTwC%2BM6nnlGwEtJ%2B1rwezDU%3D&reserved=0>.
|
|
Sorry, I'm not a programmer. Am just giving my feedback as a user! |
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi Kenton,
I'm getting a lot of good use out of the TimeCop app.
Please consider this pull request that adds a "work type" to each timer to help categorize timers.
Details:
Thanks again for a very useful program.
Best wishes and take care.
-Rich