Declare correct ws options type

[dominykas]

The original string | string[] seems to have been a confusion because the ws package client takes 3 arguments, of which the middle one (protocols) is the string | string[], but it is optional. When it is left out - it becomes the options object instead: https://github.com/websockets/ws/blob/c798dd4ee20efb2d7591b5659839ad05cdb3eb70/lib/websocket.js#L80

The type information is covered in jsdoc: https://github.com/websockets/ws/blob/c798dd4ee20efb2d7591b5659839ad05cdb3eb70/lib/websocket.js#L627

A more complete typing information is exposed by @types/ws, though.

Closes #337.

[damusix]

@dominykas Hey Dom, thanks for the PR. Two things:

1. Can you run type tests and resolve the type errors?
2. Can you add a test that validates this change of typings? A config with that typing will do. Validate that it'll connect and send a message.

[dominykas]

🤔 this is also failing on current master - probably unrelated to my change, but I'll take a look.

[dominykas]

1. Checked the details. Reverting 2132240 (basically, lab upgrade) fixes the build. The error reported comes from node_modules/@hapi/hapi/lib/types/server/events.d.ts:147:17 i.e. from Hapi itself - so the fix probably belongs there? In fact, type tests on the next branch of Hapi are failing there, although given that the types haven't changed, it's a types bug on master (even if those are not being tested in lab@25 on master).
2. Ah, I was not aware these exist 👍 plucked some examples from existing tests: 66dd37a

Seems there's also an unrelated test failing in node 22...

[Marsup]

Fixed the type issue in podium hapijs/podium#84. It looked like an innocent change, sorry for that.

[Marsup]

It should be fine now, also for node 23.

[dominykas]

Thanks!

Resolved conflicts - things are now green.