Skip to content

Conversation

@hashworks
Copy link
Collaborator

@hashworks hashworks commented Feb 1, 2025

  • Add CHANGELOG entry for the release
  • Update version number throughout
  • Update version related tests

Loosely followed the previous #1017.

@hashworks
Copy link
Collaborator Author

Feel free to delay this for additional PRs and tests. I'll update the changelog as needed.

@dimitri
Copy link
Contributor

dimitri commented Feb 1, 2025

Thanks for preparing the release. Please have a look at #1019 and more importantly how to test for upgrades. Then test for upgrades using packages, if you have time to do that.

If I remember correctly the idea was to use patch updates (2.1.1, 2.1.2, etc) when the monitor schema does not change, and minor updates (2.1 to 2.2, etc) for “bigger” updates with monitor schema change. The recent versions we published warranted a version number change of the “minor update” fashion, but did not change the monitor schema. We still need empty schema upgrade files.

@hashworks
Copy link
Collaborator Author

We still need empty schema upgrade files.

I've taken the liberty to cherry-pick e3a6da8 and added a 2.1 -> 2.2 schema upgrade file.

Closes #1019.

hashworks and others added 3 commits February 3, 2025 16:56
* Add CHANGELOG entry for the release
* Update version number throughout
* Update version related tests
@hashworks
Copy link
Collaborator Author

Please have a look at #1019 and more importantly how to test for upgrades. Then test for upgrades using packages, if you have time to do that.

I'll see what I can do.

@dimitri
Copy link
Contributor

dimitri commented Feb 3, 2025

I'll see what I can do.

See the README at https://github.com/hapostgres/pg_auto_failover/tree/main/tests/upgrade where I documented the process I used to follow before releasing new versions.

@hashworks
Copy link
Collaborator Author

Sadly I wasn't able to build the docker image with the v2.1 tag:

git switch --detach v2.1
docker build --build-arg PGVERSION=14 --target run -t pg_auto_failover_run:2_1_pg14 .

PGVERSION=13 or PGVERSION=14 results in

Step 21/61 : RUN make -s clean && make -s -j8 install
...
In file included from /usr/src/citus//src/bin/pg_send_cancellation/pg_send_cancellation.c:44:
/usr/include/postgresql/internal/libpq-int.h:84:10: fatal error: 'common/pg_prng.h' file not found

PGVERSION=15 has another error:

Step 21/61 : RUN make -s clean && make -s -j8 install
...
In file included from /usr/src/citus//src/bin/pg_send_cancellation/pg_send_cancellation.c:44:
/usr/include/postgresql/internal/libpq-int.h:503:2: error: unknown type name 'AddrInfo'
        AddrInfo   *addr;                       /* the array of addresses for the currently
        ^
1 error generated.

PGVERSION=16 fails as well:

Step 20/61 : RUN ./configure
 ---> Running in fe3c79e1d0db
checking for a sed that does not truncate output... /bin/sed
checking for gawk... gawk
checking for flex... /usr/bin/flex
configure: error: Citus is not compatible with the detected PostgreSQL version 16.

This way I'm not able to test an upgrade in the way you linked.

@xinferum
Copy link

Good afternoon, @dimitri
Can you help @hashworks with the tests and the release of the new version? We are really looking forward to the support of the 17th PostgreSQL in pg_auto_failover.

@dimitri dimitri added Packaging and CI Enhancements to our CI integration release_checklist labels Apr 3, 2025
@dimitri dimitri merged commit 8322677 into hapostgres:main Apr 3, 2025
27 checks passed
@dimitri
Copy link
Contributor

dimitri commented Apr 3, 2025

Thanks for contribution @hashworks ; I now have published the new release!

@porsager
Copy link
Collaborator

porsager commented Apr 3, 2025

Fantastic @dimitri ! Thanks a bunch ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Packaging and CI Enhancements to our CI integration release_checklist

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants