ensuring that tags does not show in branches #65
Conversation
|
Ryan Kennedy seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
dkapanidis
left a comment
dkapanidis
left a comment
There was a problem hiding this comment.
It should avoid omitting branches that may include 'tags' inside their name
git.go
Outdated
|
|
||
| // Branches list is separated by spaces. Let's put it in an array | ||
| labels = append(labels, branches...) | ||
| if !strings.Contains(branches_str, "tags") { |
There was a problem hiding this comment.
If I create a branch named "catagsarm" it will be omitted this way because it contains 'tags' inside the text.
What is your current use-case? Does your git spit your tags as branches?
There was a problem hiding this comment.
I will have to update this. When listing branches there is a branch named "tags/"
There was a problem hiding this comment.
Hey it's updated now, see how that looks?
This is quite useful for Continuous Delivery use-cases. In order for CI systems to propagate the BUILD_NUMBER to captain they can now use '-t BUILD_NUMBER' as parameter. This will create a docker image with the specific version and push it to registry with 'captain push'
|
This is still an issue when using git 2.17.1. (from a fresh install of Ubuntu 18.04) |
5 participants
Fixes issue #63 tags shows as a branch when issuing
On a tagged commit