Open
Conversation
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
Comment on lines
-21
to
+24
| columns_to_keep = [5, 6] + list(range(11,26)) + list(range(32, 103)) + [145] | ||
| columns_to_keep = [5, 6] + list(range(11,26)) + list(range(32, 103)) + [145] | ||
| crime = crime.ix[:,columns_to_keep].dropna() | ||
|
|
||
| X_crime = crime.ix[:,range(0,88)] | ||
| X_crime = crime.ix[:, range(88)] |
Author
There was a problem hiding this comment.
Function load_crime_dataset refactored with the following changes:
- Replace range(0, x) with range(x) (
remove-zero-from-range)
Comment on lines
-70
to
+74
| h = [] | ||
| for c in range(0, num_labels): | ||
| h.append(mpatches.Patch(color=color_array[c], label=class_labels[c])) | ||
| h = [ | ||
| mpatches.Patch(color=color_array[c], label=class_labels[c]) | ||
| for c in range(num_labels) | ||
| ] | ||
|
|
Author
There was a problem hiding this comment.
Function plot_labelled_scatter refactored with the following changes:
- Convert for loop into list comprehension (
list-comprehension) - Replace range(0, x) with range(x) (
remove-zero-from-range)
Comment on lines
-83
to
+86
| cmap_light = ListedColormap(color_list_light[0:numClasses]) | ||
| cmap_bold = ListedColormap(color_list_bold[0:numClasses]) | ||
| cmap_light = ListedColormap(color_list_light[:numClasses]) | ||
| cmap_bold = ListedColormap(color_list_bold[:numClasses]) |
Author
There was a problem hiding this comment.
Function plot_class_regions_for_classifier_subplot refactored with the following changes:
- Replace a[0:x] with a[:x] and a[x:len(a)] with a[x:] [×2] (
remove-redundant-slice-index) - Replace range(0, x) with range(x) (
remove-zero-from-range)
Comment on lines
-129
to
+132
| cmap_light = ListedColormap(color_list_light[0:numClasses]) | ||
| cmap_bold = ListedColormap(color_list_bold[0:numClasses]) | ||
| cmap_light = ListedColormap(color_list_light[:numClasses]) | ||
| cmap_bold = ListedColormap(color_list_bold[:numClasses]) |
Author
There was a problem hiding this comment.
Function plot_class_regions_for_classifier refactored with the following changes:
- Replace a[0:x] with a[:x] and a[x:len(a)] with a[x:] [×2] (
remove-redundant-slice-index) - Replace range(0, x) with range(x) (
remove-zero-from-range)
Comment on lines
-184
to
+189
|
|
||
| mesh_step_size = .01 # step size in the mesh | ||
| plot_symbol_size = 50 | ||
|
|
Author
There was a problem hiding this comment.
Found the following improvement in Function plot_fruit_knn:
Comment on lines
-229
to
+234
|
|
||
| mesh_step_size = .01 # step size in the mesh | ||
| plot_symbol_size = 50 | ||
|
|
Author
There was a problem hiding this comment.
Function plot_two_class_knn refactored with the following changes:
- Replace call to format with f-string (
use-fstring-for-formatting) - Replace assignment with augmented assignment (
aug-assign)
Comment on lines
-24
to
+27
| dimensions = dimensions = ['Dimension {}'.format(i) for i in range(1,len(pca.components_)+1)] | ||
| dimensions = dimensions = [ | ||
| f'Dimension {i}' for i in range(1, len(pca.components_) + 1) | ||
| ] | ||
|
|
Author
There was a problem hiding this comment.
Function pca_results refactored with the following changes:
- Replace call to format with f-string (
use-fstring-for-formatting)
Comment on lines
-100
to
+103
|
|
Author
There was a problem hiding this comment.
Found the following improvement in Function biplot:
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Branch
masterrefactored by Sourcery.If you're happy with these changes, merge this Pull Request using the Squash and merge strategy.
See our documentation here.
Run Sourcery locally
Reduce the feedback loop during development by using the Sourcery editor plugin:
Review changes via command line
To manually merge these changes, make sure you're on the
masterbranch, then run:Help us improve this pull request!