Skip to content

Conversation

@nyurik
Copy link
Contributor

@nyurik nyurik commented Jul 23, 2025

Libraries should not contain the lock file, as that does not change anything for the users of the library, but may hide bugs for the maintainers of the library itself.

P.S. Note that this used to be part of #83

Libraries should not contain the lock file, as that does not change anything for the users, but may hide bugs for the developers of the library itself.
@waywardmonkeys
Copy link

This is no longer the guidance from the Cargo team: https://blog.rust-lang.org/2023/08/29/committing-lockfiles/

@nyurik
Copy link
Contributor Author

nyurik commented Jul 23, 2025

@waywardmonkeys this is true - but is there a specific reason you want to keep the lock? Having lock means CI has to also test removing it and doing a build without it.

@dfrg
Copy link
Collaborator

dfrg commented Jul 25, 2025

We have (and intend to retain) a very small dependency graph, almost all of which we control. Given that and the desire to keep this mostly aligned with the fontations repo, I’m in favor of removing the lock file. We can restore it later if it becomes a problem.

@dfrg dfrg merged commit 3f4a0f2 into harfbuzz:main Jul 25, 2025
2 checks passed
@nyurik nyurik deleted the lock branch July 25, 2025 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants