Fix: Handle empty/whitespace inputs in process_questions and add ligh…#119
Merged
jaydugad merged 1 commit intoharmonydata:mainfrom Sep 18, 2025
Merged
Conversation
Collaborator
|
All tests are passing locally on Python 3.11, including the ones that were failing before. Going to merge this now. |
Contributor
Author
|
Hi @jaydugad, I'm very pleased to know that all the test cases are passing locally, this being my first open-source contribution means a lot to me. I would also like to contribute to more issues and solve them, also would love to connect with you on linkedin. Thanks |
Collaborator
|
That’s awesome to hear! On my GitHub account, I have added my LinkedIn profile - let's connect. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
This PR fixes a critical bug in Harmony’s matching pipeline where empty or whitespace-only inputs (e.g., "" vs "") were incorrectly producing a similarity score of 1.0.
Changes:
Impact: