Fix, use filtered valid_questions for language detection (closes #76)#123
Merged
woodthom2 merged 1 commit intoharmonydata:mainfrom Dec 5, 2025
Merged
Conversation
woodthom2
approved these changes
Dec 4, 2025
Contributor
|
Thanks Oscar! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixed a bug where the 'detect()' func was receiving unfiltered data instead of the filtered 'valid_questions' list, causing 'LangDetectException: No features in text' errors when processing Excel files with empty or invalid question text.
Fixes #76
Type of change
Testing
Test Configuration
Checklist
I hope this PR checklist suffices! Simple fix so did not include all checklist criteria :)