feat(client): set client buffer size to avoid buffer overflow#323
Open
GoldenSheep402 wants to merge 1 commit intohashicorp:mainfrom
Open
feat(client): set client buffer size to avoid buffer overflow#323GoldenSheep402 wants to merge 1 commit intohashicorp:mainfrom
GoldenSheep402 wants to merge 1 commit intohashicorp:mainfrom
Conversation
|
Thank you for your submission! We require that all contributors sign our Contributor License Agreement ("CLA") before we can accept the contribution. Read and sign the agreement Learn more about why HashiCorp requires a CLA and what the CLA includes Have you signed the CLA already but the status is still pending? Recheck it. |
sonamtenzin2
left a comment
There was a problem hiding this comment.
Please add test cases for the failure scenario
| // If this is 0, then the default of 64KB is used. | ||
| PluginLogBufferSize int | ||
|
|
||
| // ClientScanerBufferSize is the buffer size(bytes) to read from stderr for plugin log lines. |
There was a problem hiding this comment.
I think its more related to stdout than stderr
|
|
||
| // ClientScanerBufferSize is the buffer size(bytes) to read from stderr for plugin log lines. | ||
| // If this is 0, then the default of 64KB is used. | ||
| ClientScanerBufferSize int |
| github.com/hashicorp/yamux v0.1.1 // indirect | ||
| github.com/mattn/go-colorable v0.1.4 // indirect | ||
| github.com/mattn/go-isatty v0.0.10 // indirect | ||
| github.com/mattn/go-isatty v0.0.17 // indirect |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In client.go
The origin code is:
If
runner.Stdout()is bigger than 64kb, it will cause[ERROR] plugin: error encountered while scanning stdout: error="bufio.Scanner: token too long"A fixed version is:
The
ClientScanerBufferSizeis provided as a config item(default is 64KB), user can set it by themselves if their command will return a large output and avoid receiving a null result.