Simplify record fields#114
Conversation
botan/src/Botan/BlockCipher.hs
Outdated
| data MutableBlockCipher = MkMutableBlockCipher | ||
| { mutableBlockCipherType :: BlockCipher | ||
| , mutableBlockCipherCtx :: Low.BlockCipher | ||
| { algo :: BlockCipher |
There was a problem hiding this comment.
Not sure if algo is good the replacement for the type...
There was a problem hiding this comment.
Maybe something like inner?
|
There |
Ideally yes. For example, I think newtype BotanHash = MkBotanHash { runBotanHash :: Ptr BotanHashStruct }could be changed to newtype BotanHash = MkBotanHash { ptr :: Ptr BotanHashStruct } |
botan/src/Botan/BlockCipher.hs
Outdated
| data MutableBlockCipher = MkMutableBlockCipher | ||
| { mutableBlockCipherType :: BlockCipher | ||
| , mutableBlockCipherCtx :: Low.BlockCipher | ||
| { algo :: BlockCipher |
There was a problem hiding this comment.
Maybe something like inner?
|
Botan's |
jorisdral
left a comment
jorisdral
left a comment
There was a problem hiding this comment.
Looks good! Thanks for your contribution.
One small thing you missed, and then we can merge this. I'll add changelog entries in a separate PR
Co-authored-by: Joris Dral <jorisjdral@gmail.com>
|
There are some CI failures, I see. Do you want to take care of them? I could also do it, but I'd have to copy your branch and open a separate PR |
|
Sure, let me see it. |
6c83b8d
We should probably keep the record field the same name as the `ConstPtr` type from `base`.
|
@willbasky merged now. Thanks for your contribution! FYI: I've opened #117 with just a few small follow-ups, nothing major Also, just asking out of interest: are you using these libraries in your own projects? |
…-fields-followup Add changelogs for PR #114, small tweaks
|
@jorisdral |
2 participants
Resolve #96