remove Monoid constraint on MonadState CPS.WriterT#176
Merged
sjshuck merged 2 commits intohaskell:masterfrom Jan 22, 2026
Merged
remove Monoid constraint on MonadState CPS.WriterT#176sjshuck merged 2 commits intohaskell:masterfrom
sjshuck merged 2 commits intohaskell:masterfrom
Conversation
Member
|
@L0neGamer I can't approve the decision for @sjshuck but I'd suggest you also add a changelog entry. :) Did you find it was redundant through a GHC warning? |
Contributor
Author
|
I found it was redundant because I recalled that the Monad instance for writer does not require Writer, and yet when using CPS.WriterT with a state monad and a writer that did not at that moment have a Monoid constraint, I got a compile time error when I shouldn't have. for example: shouldn't fail with CPS.WriterT. There should be a warning for this, I'll dig it up (note: -Wredundant-constraints is turned on it seems but doesn't do anything here) and bump the changelog. |
Collaborator
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is unncessary, so I'm suggesting we remove it.