feat: add slient mode with cli usage#83
Open
clementlecorre wants to merge 3 commits intohasura:mainfrom
Open
Conversation
|
Beep boop! 🤖 Hey @clementlecorre, thanks for your PR! One of my human friends will review this PR and get back to you as soon as possible. Stay awesome! 😎 |
wawhal
suggested changes
May 17, 2021
Contributor
wawhal
left a comment
wawhal
left a comment
There was a problem hiding this comment.
Thanks for the PR @clementlecorre. It works :)
However, I'd suggest adding cli.action in the ctx and make it aware of the silent flag so that we don't have to check it everywhere.
Once done, we'd use ctx.action.stop instead of cli.action.stop.
Does that make sense?
clementlecorre
force-pushed
the
feautre/support-silent-mode
branch
from
7ab3200 to
e46b5c6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.