Fix container class mapped to incorrect namespace #1373
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rly
changed the title
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## dev #1373 +/- ##
==========================================
+ Coverage 92.44% 92.45% +0.01%
==========================================
Files 42 42
Lines 9765 9765
Branches 1983 1983
==========================================
+ Hits 9027 9028 +1
+ Misses 463 462 -1
Partials 275 275 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
oruebel
reviewed
Jan 10, 2026
Comment on lines
522
to
+524
| # NOTE that the type_name may appear in multiple namespaces based on how they were resolved | ||
| # but the same type_name should point to the same class | ||
| if data_type in ns_data_types: | ||
| if data_type in ns_data_types and not isinstance(ns_data_types[data_type], TypeSource): |
Contributor
There was a problem hiding this comment.
Does the comment also need to be updated? I'm not sure what isinstance(ns_data_types[data_type], TypeSource actually checks so may be worth clarifying. Otherwise this looks good so I approve and you can decide
Contributor
Author
There was a problem hiding this comment.
The comment could be a little clearer. I'll make a new PR. Sorry, this was on auto-merge.
oruebel
approved these changes
Jan 10, 2026
rly
added a commit
that referenced
this pull request
Jan 10, 2026
Clarify comment regarding TypeMap.__container_types
oruebel
pushed a commit
that referenced
this pull request
Jan 11, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
DynamicTableRegionwritten withhdmf_experimentalinstead ofhdmf_commonwhen using NWB extensions #1347 with a minimal change. Although this resolves the issue, the logic within load_namespaces and TypeMap regarding container class registration is not intuitive, and could be improved with a larger refactor as shown in Refactor load_namespaces to return source types, fix registration #1372.How to test the behavior?
Checklist
CHANGELOG.mdwith your changes?