Skip to content

Implement "Enable Stage Collision Debug View" HMM code in a safer way #1541

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
DeaTh-G wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Implement "Enable Stage Collision Debug View" HMM code in a safer way #1541

DeaTh-G wants to merge 2 commits into from

Conversation

@DeaTh-G
Copy link
Contributor

@DeaTh-G DeaTh-G commented Apr 13, 2025 •
edited
Loading

  • Change the implementation of the hmm code to mimic the behaviour of changing the field responsible for this in the XML file itself.
  • Change the execution behaviour of the code so that levels such as Rooftop Run (Day) Act 1 and the Dark Moray boss fight draw their collision previews too, despite their Stage.stg.xml files being setup in a way where it wouldn't.

@DeaTh-G DeaTh-G linked an issue Apr 13, 2025 that may be closed by this pull request
Code "Enable Stage Collision Debug View" disables collision in Rooftop Run + crash prone. #1369
Open
9 tasks
@DeaTh-G DeaTh-G force-pushed the collision-render-code-fix branch from 4b61b22 to 642179d Compare February 1, 2026 10:33
@DeaTh-G DeaTh-G marked this pull request as ready for review February 1, 2026 10:33
@DeaTh-G DeaTh-G force-pushed the collision-render-code-fix branch from 642179d to ea86d8b Compare February 1, 2026 10:50
@DeaTh-G DeaTh-G added the hmm code Issue caused by a feature exposed as a hmm code label Feb 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@blueskythlikesclouds blueskythlikesclouds Awaiting requested review from blueskythlikesclouds

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

hmm code Issue caused by a feature exposed as a hmm code

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Code "Enable Stage Collision Debug View" disables collision in Rooftop Run + crash prone.

1 participant

@DeaTh-G