Skip to content

Fix DateType #20

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
koertho merged 1 commit into from
Jul 26, 2021
Merged

Fix DateType #20

koertho merged 1 commit into from
Jul 26, 2021

Conversation

@koertho
Copy link
Contributor

@koertho koertho commented Jul 23, 2021

This PR fixes Datetype not working "standalone".

Defcon0
Defcon0 reviewed Jul 23, 2021
View reviewed changes
Copy link
Contributor

@Defcon0 Defcon0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Did you test if date range still works?

@koertho
Copy link
Contributor Author

koertho commented Jul 23, 2021 •
edited
Loading

@Defcon0 No, but it skips following date types so the code should not be executed.
(which is also not the best design to make this depends on the order, but this could easily fixed after #19 is merged)

Defcon0
Defcon0 approved these changes Jul 23, 2021
View reviewed changes
Copy link
Contributor

@Defcon0 Defcon0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, clear :-) Thanks for fixing.

@koertho koertho merged commit dd7afc3 into master Jul 26, 2021
@koertho koertho deleted the fix/DateType branch July 26, 2021 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@Defcon0 Defcon0 Defcon0 approved these changes

@AlexejKossmann AlexejKossmann AlexejKossmann approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@koertho @Defcon0 @AlexejKossmann