added profile and services for hemitrap in testnet#8
Conversation
|
Question - Do we want to do this as a part of the existing |
|
@joshuasing it shares volumes with the original compose file, namely the the steps are:
it will pick up where that synced node left off and work on its own fork |
jcvernaleo
left a comment
There was a problem hiding this comment.
You need to add this to the documentation.
@jcvernaleo added 👍 let me know if you want me to add anything else |
testnet/docker-compose.yml
Outdated
| - hemitrap | ||
| environment: | ||
| ANVIL_IP_ADDR: '0.0.0.0' | ||
| image: ghcr.io/foundry-rs/foundry:latest |
There was a problem hiding this comment.
Please pin this to a specific tag and sha256 digest:
| image: ghcr.io/foundry-rs/foundry:latest | |
| image: ghcr.io/foundry-rs/foundry:v1.4.1@sha256:629bebb49d1ba44a52a9fc14229dd58930e3193b4b206ae43ad00089e9ead95b |
There was a problem hiding this comment.
This doesn't seem to have been resolved
jcvernaleo
left a comment
There was a problem hiding this comment.
My concern was covered so I'm hitting approve but looks like @joshuasing's may not be addressed yet and I do think those are important too (the docker image ones in particular.
* added a new profile in the testnet docker compose called "hemitrap". this profile sets up a forked network of our testnet to test deploying smart contract updatest, then running localnet tests against them * there is explicitly no README added; this is simply a new docker compose profile to be used by the greater ecosystem
0e7d1bf to
5a97fba
Compare
Co-authored-by: Joshua Sing <joshua@hemi.xyz>
Summary
Changes
see summary.