🚮 Sweep experiments older than 2020-02-01#2
Draft
github-actions[bot] wants to merge 7 commits intomasterfrom
Draft
🚮 Sweep experiments older than 2020-02-01#2github-actions[bot] wants to merge 7 commits intomasterfrom
github-actions[bot] wants to merge 7 commits intomasterfrom
Conversation
Previous history on prod-config.json: - 0ab715e - 2019-10-01T10:32:36-04:00 - Launch <amp-action-macro>
Previous history on prod-config.json: - d26327a - 2018-11-05T12:02:25-05:00 - Re-launch amp-story-responsive-units experiment - d5ec88b - 2018-10-30T16:01:59-07:00 - Unlaunch amp-story-responsive-units for urgent release - 65379df - 2018-10-26T15:27:09-04:00 - Launch amp-story-responsive-units experiment
Previous history on prod-config.json: - 366b9d5 - 2018-07-11T12:03:09-04:00 - Revert "Remove launched experiments. (ampproject#16528)" - 3a3dbd9 - 2018-07-06T14:47:49-04:00 - Remove launched experiments. - 1194c16 - 2018-06-12T11:38:38-04:00 - Start canonical adsense fast fetch experiments at 1%
Previous history on prod-config.json: - 366b9d5 - 2018-07-11T12:03:09-04:00 - Revert "Remove launched experiments. (ampproject#16528)" - 3a3dbd9 - 2018-07-06T14:47:49-04:00 - Remove launched experiments. - 34ffcdb - 2017-02-17T13:10:59-08:00 - turn on chunked-amp
Previous history on prod-config.json: - 4ca1409 - 2019-10-28T15:54:36+00:00 - Ramp down inconsistent height selection fix experiment to 0%. This doesn't work very well on desktop / tablet so we need to fix that before proceeding.
Previous history on prod-config.json: - ca20059 - 2017-05-16T09:31:30-04:00 - Start Doubleclick Fast Fetch potential SRA delay measure experiment
Sweep experiments last flipped globally up to 2020-02-01: - (2019-10-01, 0ab715e) `amp-action-macro`: 1 - (2018-11-05, d26327a) `amp-story-responsive-units`: 1 - (2018-07-11, 366b9d5) `amp-story-v1`: 1 - (2018-07-11, 366b9d5) `chunked-amp`: 1 - (2019-10-28, 4ca1409) `fix-inconsistent-responsive-height-selection`: 0 - (2017-05-16, ca20059) `pump-early-frame`: 1 --- ###⚠️ Javascript source files require intervention The following may contain errors and/or require intervention to remove superfluous conditionals: - `extensions/amp-action-macro/0.1/amp-action-macro.js` - `extensions/amp-action-macro/0.1/test/test-amp-action-macro.js` - `extensions/amp-story/1.0/amp-story.js` - `extensions/amp-story/1.0/test/test-amp-story.js` - `src/runtime.js` - `test/unit/test-runtime.js` Refer to the removal guide for [suggestions on handling these modified Javascript files.](https://github.com/ampproject/amphtml/blob/master/build-system/tasks/sweep-experiments/README.md#followup) --- ###⚠️ HTML files may still contain references The following HTML files contain references to experiment names which may be stale and should be manually removed: - `examples/amp-action-macro.html` Refer to the removal guide for [suggestions on handling these HTML files.](https://github.com/ampproject/amphtml/blob/master/build-system/tasks/sweep-experiments/README.md#followup:html)
Author
|
You may checkout this pull request to follow-up manually: |
henel677
pushed a commit
that referenced
this pull request
Jun 30, 2021
…mpproject#35023) * Add runtime service to handle execute tasks like adding ports to the network. - Add entry points to wrapper such as creating PortOperator and adding ports. - Update compile script since it can perform as normal Closure compiler. * Fix lint errors. * Remove externs.js since the compiled code with it would keep 'goog' hence violate JSC_CANNOT_HAVE_MODULE_VAR_NAMED_GOOG. * Construct channel with FrameService iframe and add it to the network. - Add DeferredChannel to the network first and resolve it after the real channel is constructed. - Ensure FrameService port is always added before any widget initialization * Report available widgets to FrameService so that it can request widget ports to listen on. - Add protocol buffer library to generate FrameService protocol - Report widget by sending messages to FrameService's RespondingChannel. - Add necessary endpoints to Closure custom API. * Move proto library to third_party folder. - Move entire proto folder to third_party folder - Update whitelist and source globs for new third_party library - Add exports file so that 'require' can be avoided in the extension * Fix source glob error. * Fix source glob error #2. * Update protoc from protobug Github repo. * Remove assistjs extension and all relevant libraries.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sweep experiments last flipped globally up to 2020-02-01:
amp-action-macro: 1amp-story-responsive-units: 1amp-story-v1: 1chunked-amp: 1fix-inconsistent-responsive-height-selection: 0pump-early-frame: 1The following may contain errors and/or require intervention to remove superfluous conditionals:
extensions/amp-action-macro/0.1/amp-action-macro.jsextensions/amp-action-macro/0.1/test/test-amp-action-macro.jsextensions/amp-story/1.0/amp-story.jsextensions/amp-story/1.0/test/test-amp-story.jssrc/runtime.jstest/unit/test-runtime.jsRefer to the removal guide for suggestions on handling these modified Javascript files.
The following HTML files contain references to experiment names which may be stale and should be manually removed:
examples/amp-action-macro.htmlRefer to the removal guide for suggestions on handling these HTML files.