-
Notifications
You must be signed in to change notification settings - Fork 235
refactor: migrate pg backups pt 7 to esm #3462
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
michaelmalave
wants to merge
7
commits into
v11.0.0
Choose a base branch
from
mm/refactor/pg-backups-pt-7
base: v11.0.0
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ning to esm and adding testing coverage
…ning to esm and adding testing coverage
18088c2 to
77a268f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Migrated 7
pg:backupscommands fromsrc/oldCommandstosrc/commandsand updated them to use ESM and the new UX helpers from@heroku/heroku-cli-util(hux). Replacedux.logwithux.stdout, replaced lodash sorts with native JavaScript, and updated all imports for ESM compatibility. Fixednls.tsto work with ESM by usingreadFileSyncinstead of JSON imports. Updated and fixed all unit tests to work with the newhux.table()output format.Type of Change
Verification
Test in a non-private space database. You can test with an essential-0 database.
To create one:
heroku addons:create heroku-postgresql:essential-0 -app $APP_NAMEAdditional Context
ux.logwithux.stdoutper@oclif/coreAPIlodash.sortBywith nativeArray.prototype.sort().jsextensions for ESM compatibilityremoveAllWhitespace()helper for flexible table output matching (following pattern fromreleases/index.unit.test.ts)backupsFactoryintest/helpers/wrappers/backups-wrapper.tsto enable mocking in testsRelated Issue
Closes #W-19701068