pyproject.toml: remove dependency on pip #82
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The dependency on pip apparently comes via spacy, but spacy is only an optional dependency in some languages settings. Therefore, we don't need to require it for all installations. Pip is a large and unwieldy dependency, so better to avoid requiring all installations to install it.
Contributor
|
It's important, see the comment there... it's there for a reason. at least we should keep it for [en] feature flag |
Author
|
In that case it should be included in the en optional dependencies |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The dependency on pip apparently comes via spacy, but spacy is only an optional dependency in some languages settings. Therefore, we don't need to require it for all installations. Pip is a large and unwieldy dependency, so better to avoid requiring all installations to install it.
There are no instances of pip being used within misaki itself: https://github.com/search?q=repo%3Ahexgrad%2Fmisaki%20pip&type=code