Conversation
|
@SukkaW review please |
SukkaW
left a comment
There was a problem hiding this comment.
I myself don't like the idea of pre-exists certificate.
What about using mkcert of some sort?
|
|
Agreed, pre-exists certificate may be difficult to trust |
Then, what is the solution? Should auto certificate creation be made? |
|
Btw, this feature no need user to install the certificate into their computer. This certificate only for NodeJS http server. So, this feature does not harm its users. |
At least the certificate should be generated per hexo project and on users' computers. We can store the generated certificates under the You can refer to vercel/next.js#54016 for the implementation. They are utilizing
This is just not even remotely a good practice. Let's avoid it. |
check the update |
lib/server-ssl.js
Outdated
There was a problem hiding this comment.
Is it possible to have only one server.js? I.e., merging servel-ssl and serve-http. I see many repeated logics here.
There was a problem hiding this comment.
please check my optimization
Co-authored-by: Sukka <github@skk.moe> Signed-off-by: Dimas Lanjaka <dimaslanjaka@gmail.com>
Co-authored-by: Sukka <github@skk.moe> Signed-off-by: Dimas Lanjaka <dimaslanjaka@gmail.com>
Co-authored-by: Sukka <github@skk.moe> Signed-off-by: Dimas Lanjaka <dimaslanjaka@gmail.com>
Co-authored-by: Sukka <github@skk.moe> Signed-off-by: Dimas Lanjaka <dimaslanjaka@gmail.com>
check list
Description
fix #340
Add SSL support for localhost. [FEATURE REQUEST] issue
Additional information
accessing from custom local domain
accessing from https://localhost:4000
accessing from local network
homepage
gallery
post asset link
How to test
check it https://github.com/dimaslanjaka/hexo-themes