WIP: Allow publish handle files with filenames separated by spaces#5476
WIP: Allow publish handle files with filenames separated by spaces#5476yapinxxx wants to merge 3 commits intohexojs:masterfrom
publish handle files with filenames separated by spaces#5476Conversation
How to testgit clone -b draft_filename https://github.com/yapinxxx/hexo.git
cd hexo
npm install
npm test |
SukkaW
left a comment
SukkaW
left a comment
There was a problem hiding this comment.
Would you like to create a test case against your changes?
If you could assist me in creating a test case, I would greatly appreciate it. Before submitting my change, I experimented with modifications in the node_modules directory to test my idea. Once I confirmed the concept could work, I directly edited the TypeScript source code. However, I faced challenges building the project and comparing changes before and after, so I submitted the pull request without a comparison. Additionally, creating a test case proved difficult due to my limited expertise in front-end development. |
Hello @SukkaW , |
You are introducing a new behavior (correct handling of the special filename) that doesn't exist in the current version of Hexo. You will need to add a test case to make sure that Hexo will always handle the special filename properly. So in the future when we run |
yapinxxx
force-pushed
the
draft_filename
branch
2 times, most recently
from
7e4d138 to
5d31f02
Compare
…t_folder` is enabled (hexojs#5473)
… spaces in the _draft folder.
yapinxxx
changed the title
publish handle files with filenames separated by spacespublish handle files with filenames separated by spaces
3 participants
Allow the publish command to handle files with filenames separated by spaces in the _draft folder.
What does it do?
The update enables filenames to include spaces in the
_draftfolder.However, the source code modifies the original filename(
data.slug) and then incorrectly compares it with the filenames in the_draftfolder, leading to erroneous results.