Skip to content

AutoFix PR #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
heyandyj merged 1 commit into from
Jan 28, 2025
Merged

AutoFix PR #2

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions flask_webgoat/users.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,13 +35,13 @@ def create_user():
)

# vulnerability: SQL Injection
query = (
"INSERT INTO user (username, password, access_level) VALUES ('%s', '%s', %d)"
% (username, password, int(access_level))
)
# mitigation: use parameterized query
query = "INSERT INTO user (username, password, access_level) VALUES (?, ?, ?)"

try:
query_db(query, [], False, True)
query_db(query, (username, password, int(access_level)), False, True)
return jsonify({"success": True})
except sqlite3.Error as err:
return jsonify({"error": "could not create user:" + err})
return jsonify({"error": "could not create user:" + str(err)})


Loading