Skip to content

Conversation

@h4apo
Copy link

@h4apo h4apo commented Mar 26, 2020

Add function generateErrorMessage that recursively goes through the validation error and generates a message containing the reason of failed validation.

@codecov-io
Copy link

codecov-io commented Mar 28, 2020

Codecov Report

Merging #167 into master will not change coverage by %.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #167   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            3         3           
  Lines          429       429           
  Branches        61        61           
=========================================
  Hits           429       429           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ad0fb9b...ec94d75. Read the comment docs.

@gphfour
Copy link
Collaborator

gphfour commented Jun 3, 2020

@h4apo I suggest we don't merge the PR since the ValidationError message is mostly meant for technical people and it shouldn't be shown to users in normal circumstances. Additionally, the users should be shown a more user friendly message instead of a detail description of the error if that's the case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants